Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture metadata from VCF header #136

Merged
merged 4 commits into from
Feb 7, 2025
Merged

Conversation

ollietulloch
Copy link
Contributor

This PR allows storage of VCF metadata at the File and then Table level.

Config in table mappings tells the file handler identifies metadata and what to label it as. The File handler then passes the metadata to the Table, where it can be accessed downstream.

bshand
bshand previously approved these changes Feb 6, 2025
Copy link
Contributor

@bshand bshand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I've flagged one possible typo.

docs/vcf-file-metadata.md Outdated Show resolved Hide resolved
Copy link
Contributor

@bshand bshand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me. I've merged in the main branch, and tests are passing again.

@ollietulloch ollietulloch merged commit 1a8c6b9 into main Feb 7, 2025
20 checks passed
@ollietulloch ollietulloch deleted the feature/vcf-file-metadata branch February 7, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants